fix: call onClose when askAi is active#2810
Closed
mguida22 wants to merge 1 commit into
Closed
Conversation
👷 Deploy request for docsearch pending review.Visit the deploys page to approve it
|
✅ Deploy Preview for docsearch-demo ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
8bittitan
reviewed
Dec 2, 2025
| function onKeyDown(event: KeyboardEvent): void { | ||
| if (isOpen && event.code === 'Escape' && isAskAiActive) { | ||
| onAskAiToggle(false); | ||
| onClose(); |
Contributor
There was a problem hiding this comment.
I don't believe these are the correct places for this. This block is meant to "leave" the Ask AI experience and go back to the keyword search experience, without closing the modal.
I believe the issue is more that the cleanup of this useEffect is not getting ran, causing the keydown event listener to never get removed.
The root issue for the modal opening again is that we focus the search button on close, and then have a listener that opens the modal again on keypress if the search button is the focused element.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Calls
onClosewhen closing the modal viaEscapeandisAskAiActiveis true. This follows the behavior of anEscapekeypress whenisAskAiActiveis false.Fixes #2809.
(this is a guess, I still need to figure out testing this)